diff options
| author | Christoph Hellwig <hch@infradead.org> | 2011-08-23 10:28:03 +0200 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2011-10-12 04:14:59 +0200 |
| commit | 375ec69d2ef6e0797f19f5823e36e249765c3d41 (patch) | |
| tree | 5c41cec41a3f8e852bb55500be6ed22efa30290c /fs/xfs | |
| parent | xfs: don't serialise adjacent concurrent direct IO appending writes (diff) | |
| download | linux-375ec69d2ef6e0797f19f5823e36e249765c3d41.tar.xz linux-375ec69d2ef6e0797f19f5823e36e249765c3d41.zip | |
xfs: remove delwri buffer handling from xfs_buf_iorequest
We cannot ever reach xfs_buf_iorequest for a buffer with XBF_DELWRI set,
given that all write handlers make sure that the buffer is remove from
the delwri queue before, and we never do reads with the XBF_DELWRI flag
set (which the code would not handle correctly anyway).
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_buf.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index c57836dc778f..2e71a26da22e 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1275,15 +1275,10 @@ xfs_buf_iorequest( { trace_xfs_buf_iorequest(bp, _RET_IP_); - if (bp->b_flags & XBF_DELWRI) { - xfs_buf_delwri_queue(bp, 1); - return 0; - } + ASSERT(!(bp->b_flags & XBF_DELWRI)); - if (bp->b_flags & XBF_WRITE) { + if (bp->b_flags & XBF_WRITE) xfs_buf_wait_unpin(bp); - } - xfs_buf_hold(bp); /* Set the count to 1 initially, this will stop an I/O |