diff options
| author | Christoph Hellwig <hch@lst.de> | 2016-10-20 06:49:03 +0200 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2016-10-20 06:49:03 +0200 |
| commit | a62e82b35b97e60e9e22a4e303900f342139822f (patch) | |
| tree | 59cb362b3750845f992dd70f578ddcacda986bac /fs/xfs | |
| parent | xfs: remove the same fs check from xfs_file_share_range (diff) | |
| download | linux-a62e82b35b97e60e9e22a4e303900f342139822f.tar.xz linux-a62e82b35b97e60e9e22a4e303900f342139822f.zip | |
xfs: fix the same_inode check in xfs_file_share_range
The VFS i_ino is an unsigned long, while XFS inode numbers are 64-bit
wide, so checking i_ino for equality could lead to rate false positives
on 32-bit architectures. Just compare the inode pointers themselves
to be safe.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 194f8f396e4d..d5b835e82b2d 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -965,7 +965,7 @@ xfs_file_share_range( IS_SWAPFILE(inode_out)) return -ETXTBSY; - same_inode = (inode_in->i_ino == inode_out->i_ino); + same_inode = (inode_in == inode_out); /* Don't reflink dirs, pipes, sockets... */ if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode)) |