diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2019-03-23 02:10:22 +0100 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2019-03-25 16:03:29 +0100 |
| commit | ed79dac98c5e9f8471456afe2cc09a3912586b52 (patch) | |
| tree | 8c6cc62bf32cca22fcf480f87760038d80399c73 /fs/xfs | |
| parent | xfs: always init bma in xfs_bmapi_write (diff) | |
| download | linux-ed79dac98c5e9f8471456afe2cc09a3912586b52.tar.xz linux-ed79dac98c5e9f8471456afe2cc09a3912586b52.zip | |
xfs: prohibit fstrim in norecovery mode
The xfs fstrim implementation uses the free space btrees to find free
space that can be discarded. If we haven't recovered the log, the bnobt
will be stale and we absolutely *cannot* use stale metadata to zap the
underlying storage.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_discard.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c index 93f07edafd81..9ee2a7d02e70 100644 --- a/fs/xfs/xfs_discard.c +++ b/fs/xfs/xfs_discard.c @@ -161,6 +161,14 @@ xfs_ioc_trim( return -EPERM; if (!blk_queue_discard(q)) return -EOPNOTSUPP; + + /* + * We haven't recovered the log, so we cannot use our bnobt-guided + * storage zapping commands. + */ + if (mp->m_flags & XFS_MOUNT_NORECOVERY) + return -EROFS; + if (copy_from_user(&range, urange, sizeof(range))) return -EFAULT; |