summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2011-04-15 23:34:18 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2011-04-16 00:28:22 +0200
commit47c2199b6eb5fbe38ddb844db7cdbd914d304f9c (patch)
treebdb4afa93c3236ec79374da9b4f47b1eb9c72548 /fs
parentSUNRPC: Fix the SUNRPC Kerberos V RPCSEC_GSS module dependencies (diff)
downloadlinux-47c2199b6eb5fbe38ddb844db7cdbd914d304f9c.tar.xz
linux-47c2199b6eb5fbe38ddb844db7cdbd914d304f9c.zip
NFSv4.1: Ensure state manager thread dies on last umount
Currently, the state manager may continue to try recovering state forever even after the last filesystem to reference that nfs_client has umounted. Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: stable@kernel.org
Diffstat (limited to 'fs')
-rw-r--r--fs/nfs/nfs4state.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index a6804f704d9d..4dfb34b43ffb 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -1607,7 +1607,7 @@ static void nfs4_state_manager(struct nfs_client *clp)
int status = 0;
/* Ensure exclusive access to NFSv4 state */
- for(;;) {
+ do {
if (test_and_clear_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) {
/* We're going to have to re-establish a clientid */
status = nfs4_reclaim_lease(clp);
@@ -1691,7 +1691,7 @@ static void nfs4_state_manager(struct nfs_client *clp)
break;
if (test_and_set_bit(NFS4CLNT_MANAGER_RUNNING, &clp->cl_state) != 0)
break;
- }
+ } while (atomic_read(&clp->cl_count) > 1);
return;
out_error:
printk(KERN_WARNING "Error: state manager failed on NFSv4 server %s"