diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-01-24 09:39:22 +0100 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2012-01-24 17:37:19 +0100 |
| commit | 803ab977618eae2b292cda0a97eed75f42250ddf (patch) | |
| tree | 846b9d4086148ea91c440dde2b8ef5131ce6ecc2 /fs | |
| parent | migrate_mode.h is not exported to user mode (diff) | |
| download | linux-803ab977618eae2b292cda0a97eed75f42250ddf.tar.xz linux-803ab977618eae2b292cda0a97eed75f42250ddf.zip | |
cifs: NULL dereference on allocation failure
We should just return directly here, the goto causes a NULL dereference.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/connect.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 986709a8d903..026d6464335b 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -3857,10 +3857,8 @@ cifs_construct_tcon(struct cifs_sb_info *cifs_sb, uid_t fsuid) struct smb_vol *vol_info; vol_info = kzalloc(sizeof(*vol_info), GFP_KERNEL); - if (vol_info == NULL) { - tcon = ERR_PTR(-ENOMEM); - goto out; - } + if (vol_info == NULL) + return ERR_PTR(-ENOMEM); vol_info->local_nls = cifs_sb->local_nls; vol_info->linux_uid = fsuid; |