diff options
| author | Tejun Heo <htejun@gmail.com> | 2007-09-20 09:05:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-12 23:51:10 +0200 |
| commit | 50ab1a72863b1ad4b117862bc52610f8d4535609 (patch) | |
| tree | 41a30dce0ef44917f16d2bc5cdf23cc26f4fac3a /fs | |
| parent | sysfs: kill unnecessary sysfs_get() in open paths (diff) | |
| download | linux-50ab1a72863b1ad4b117862bc52610f8d4535609.tar.xz linux-50ab1a72863b1ad4b117862bc52610f8d4535609.zip | |
sysfs: kill unnecessary NULL pointer check in sysfs_release()
In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist. Kill the unnecessary NULL check. This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/sysfs/file.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 73333dc68545..8f1ebd88b9ce 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -311,11 +311,10 @@ static int sysfs_release(struct inode * inode, struct file * filp) { struct sysfs_buffer *buffer = filp->private_data; - if (buffer) { - if (buffer->page) - free_page((unsigned long)buffer->page); - kfree(buffer); - } + if (buffer->page) + free_page((unsigned long)buffer->page); + kfree(buffer); + return 0; } |