summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2013-02-02 02:07:21 +0100
committerTheodore Ts'o <tytso@mit.edu>2013-02-02 02:07:21 +0100
commit524c19ebc961799b1ec126e4b063b941a70275e5 (patch)
tree7307132472ee3f01fae5d04cdce66bc84dfa3b87 /fs
parentjbd2: don't wake kjournald unnecessarily (diff)
downloadlinux-524c19ebc961799b1ec126e4b063b941a70275e5.tar.xz
linux-524c19ebc961799b1ec126e4b063b941a70275e5.zip
ext4: use WARN in ext4_alloc_blocks
Use WARN rather than printk followed by WARN_ON(1), for conciseness. A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression list es; @@ -printk( +WARN(1, es); -WARN_ON(1); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/indirect.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c
index bdd20231e66c..193281098fb6 100644
--- a/fs/ext4/indirect.c
+++ b/fs/ext4/indirect.c
@@ -358,9 +358,8 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode,
* for the first direct block
*/
new_blocks[index] = current_block;
- printk(KERN_INFO "%s returned more blocks than "
+ WARN(1, KERN_INFO "%s returned more blocks than "
"requested\n", __func__);
- WARN_ON(1);
break;
}
}