diff options
| author | Louis Rilling <Louis.Rilling@kerlabs.com> | 2008-06-12 17:26:47 +0200 |
|---|---|---|
| committer | Mark Fasheh <mfasheh@suse.com> | 2008-07-14 22:57:16 +0200 |
| commit | e75206517504461778c283b942440ef312e437d5 (patch) | |
| tree | a0acb0d8cc4527fc00560d7b78a971100fba7f57 /fs | |
| parent | configfs: Allow ->make_item() and ->make_group() to return detailed errors. (diff) | |
| download | linux-e75206517504461778c283b942440ef312e437d5.tar.xz linux-e75206517504461778c283b942440ef312e437d5.zip | |
configfs: call drop_link() to cleanup after create_link() failure
When allow_link() succeeds but create_link() fails, the subsystem is not
informed of the failure.
This patch fixes this by calling drop_link() on create_link() failures.
Signed-off-by: Louis Rilling <Louis.Rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/configfs/symlink.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c index faeb4417a10d..0004d18c40ac 100644 --- a/fs/configfs/symlink.c +++ b/fs/configfs/symlink.c @@ -140,8 +140,12 @@ int configfs_symlink(struct inode *dir, struct dentry *dentry, const char *symna goto out_put; ret = type->ct_item_ops->allow_link(parent_item, target_item); - if (!ret) + if (!ret) { ret = create_link(parent_item, target_item, dentry); + if (ret && type->ct_item_ops->drop_link) + type->ct_item_ops->drop_link(parent_item, + target_item); + } config_item_put(target_item); path_put(&nd.path); |