diff options
author | J. Bruce Fields <bfields@redhat.com> | 2011-01-04 20:12:47 +0100 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2011-01-04 22:49:25 +0100 |
commit | fdef7aa5d4020fd94ffcbf0078d6bd9e5a111e19 (patch) | |
tree | 270c2b03e9cb5cf5451b0e229c5a328727ef743a /fs | |
parent | svcrpc: take lock on turning entry NEGATIVE in cache_check (diff) | |
download | linux-fdef7aa5d4020fd94ffcbf0078d6bd9e5a111e19.tar.xz linux-fdef7aa5d4020fd94ffcbf0078d6bd9e5a111e19.zip |
svcrpc: ensure cache_check caller sees updated entry
Supposes cache_check runs simultaneously with an update on a different
CPU:
cache_check task doing update
^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
1. test for CACHE_VALID 1'. set entry->data
& !CACHE_NEGATIVE
2. use entry->data 2'. set CACHE_VALID
If the two memory writes performed in step 1' and 2' appear misordered
with respect to the reads in step 1 and 2, then the caller could get
stale data at step 2 even though it saw CACHE_VALID set on the cache
entry.
Add memory barriers to prevent this.
Reviewed-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions