diff options
| author | Arjan van de Ven <arjan@linux.intel.com> | 2008-09-14 04:51:30 +0200 |
|---|---|---|
| committer | Alexey Dobriyan <adobriyan@gmail.com> | 2008-10-23 11:34:38 +0200 |
| commit | 6c2f91e077f1b60e7f83b7ee044f965f469cfdb3 (patch) | |
| tree | 98e31d603d80a03325e6c0903e9d352823b04e30 /fs | |
| parent | proc: spread __init (diff) | |
| download | linux-6c2f91e077f1b60e7f83b7ee044f965f469cfdb3.tar.xz linux-6c2f91e077f1b60e7f83b7ee044f965f469cfdb3.zip | |
proc: use WARN() rather than printk+backtrace
Use WARN() rather than a printk() + backtrace();
this gives a more standard format message as well as complete
information (including line numbers etc) that will be collected
by kerneloops.org
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/proc/generic.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 7821589a17d5..60a359b35582 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -547,9 +547,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp for (tmp = dir->subdir; tmp; tmp = tmp->next) if (strcmp(tmp->name, dp->name) == 0) { - printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n", + WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n", dir->name, dp->name); - dump_stack(); break; } |