diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2013-05-10 20:50:24 +0200 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2013-06-19 15:16:47 +0200 |
| commit | ee8be57bc331f00d520c4c8a78ffa9590ed41c2c (patch) | |
| tree | b7033ab0c9a2836105da401a0de09278139fa759 /fs | |
| parent | Add wait_on_atomic_t() and wake_up_atomic_t() (diff) | |
| download | linux-ee8be57bc331f00d520c4c8a78ffa9590ed41c2c.tar.xz linux-ee8be57bc331f00d520c4c8a78ffa9590ed41c2c.zip | |
fs/fscache: remove spin_lock() from the condition in while()
The spinlock() within the condition in while() will cause a compile error
if it is not a function. This is not a problem on mainline but it does not
look pretty and there is no reason to do it that way.
That patch writes it a little differently and avoids the double condition.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-By: Milosz Tanski <milosz@adfin.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/fscache/page.c | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/fs/fscache/page.c b/fs/fscache/page.c index ff000e52072d..4882c806253f 100644 --- a/fs/fscache/page.c +++ b/fs/fscache/page.c @@ -796,11 +796,16 @@ void fscache_invalidate_writes(struct fscache_cookie *cookie) _enter(""); - while (spin_lock(&cookie->stores_lock), - n = radix_tree_gang_lookup_tag(&cookie->stores, results, 0, - ARRAY_SIZE(results), - FSCACHE_COOKIE_PENDING_TAG), - n > 0) { + for (;;) { + spin_lock(&cookie->stores_lock); + n = radix_tree_gang_lookup_tag(&cookie->stores, results, 0, + ARRAY_SIZE(results), + FSCACHE_COOKIE_PENDING_TAG); + if (n == 0) { + spin_unlock(&cookie->stores_lock); + break; + } + for (i = n - 1; i >= 0; i--) { page = results[i]; radix_tree_delete(&cookie->stores, page->index); @@ -812,7 +817,6 @@ void fscache_invalidate_writes(struct fscache_cookie *cookie) page_cache_release(results[i]); } - spin_unlock(&cookie->stores_lock); _leave(""); } |