diff options
| author | Steve French <smfrench@gmail.com> | 2015-03-27 07:15:02 +0100 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2015-04-01 07:01:47 +0200 |
| commit | c85c35f8fc1d3f5ca60cd713f10af387de73cb94 (patch) | |
| tree | 2c074253f31dc4095b192b2c311f0039c70083d7 /fs | |
| parent | Fix coverity warning (diff) | |
| download | linux-c85c35f8fc1d3f5ca60cd713f10af387de73cb94.tar.xz linux-c85c35f8fc1d3f5ca60cd713f10af387de73cb94.zip | |
Fix warning on impossible comparison
workstation_RFC1001_name is part of the struct and can't be null,
remove impossible comparison (array vs. null)
Pointed out by Coverity (CID 140095)
Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/connect.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index cdb1aaf295b1..480cf9c81d50 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server) * calling name ends in null (byte 16) from old smb * convention. */ - if (server->workstation_RFC1001_name && - server->workstation_RFC1001_name[0] != 0) + if (server->workstation_RFC1001_name[0] != 0) rfc1002mangle(ses_init_buf->trailer. session_req.calling_name, server->workstation_RFC1001_name, |