diff options
| author | Denis Efremov <yefremov.denis@gmail.com> | 2013-10-25 13:53:25 +0200 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2013-10-30 21:53:14 +0100 |
| commit | 5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b (patch) | |
| tree | b332e43e4d76d1a100ddb658eab9e55d0433e3b9 /fs | |
| parent | xfs: prevent stack overflows from page cache allocation (diff) | |
| download | linux-5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b.tar.xz linux-5bf1f439c89d4653f8cc8f8aa303e0d6991aba4b.zip | |
xfs:xfs_dir2_node.c: pointer use before check for null
ASSERT on args takes place after args dereference.
This assertion is redundant since we are going to panic anyway.
Found by Linux Driver Verification project (linuxtesting.org) -
PVS-Studio analyzer.
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_dir2_node.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c index f90bf0690346..56369d4509d5 100644 --- a/fs/xfs/xfs_dir2_node.c +++ b/fs/xfs/xfs_dir2_node.c @@ -1327,7 +1327,6 @@ xfs_dir2_leafn_split( args = state->args; dp = args->dp; mp = dp->i_mount; - ASSERT(args != NULL); ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC); error = xfs_da_grow_inode(args, &blkno); if (error) { |