diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2006-04-01 01:37:06 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-02 22:03:31 +0200 |
| commit | 6e0dd741a89be35defa05bd79f4211c5a2762825 (patch) | |
| tree | 565d0328e9e353884e9d5785590e6d4be99e0964 /fs | |
| parent | [PATCH] revert incorrect mutex conversion in hdaps driver (diff) | |
| download | linux-6e0dd741a89be35defa05bd79f4211c5a2762825.tar.xz linux-6e0dd741a89be35defa05bd79f4211c5a2762825.zip | |
[PATCH] sysfs: zero terminate sysfs write buffers
No one should be writing a PAGE_SIZE worth of data to a normal sysfs
file, so properly terminate the buffer.
Thanks to Al Viro for pointing out my supidity here.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/sysfs/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 830f76fa098c..f1cb1ddde511 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -183,7 +183,7 @@ fill_write_buffer(struct sysfs_buffer * buffer, const char __user * buf, size_t return -ENOMEM; if (count >= PAGE_SIZE) - count = PAGE_SIZE; + count = PAGE_SIZE - 1; error = copy_from_user(buffer->page,buf,count); buffer->needs_read_fill = 1; return error ? -EFAULT : count; |