diff options
| author | Filipe Manana <fdmanana@suse.com> | 2015-06-10 13:55:41 +0200 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2015-07-02 02:17:19 +0200 |
| commit | 9c6429d96daec64f6b5b10a1c6b02c7264541ea1 (patch) | |
| tree | a6457331bf7b6053afd8bddd6001f631c3de5f86 /fs | |
| parent | Btrfs: fix memory corruption on failure to submit bio for direct IO (diff) | |
| download | linux-9c6429d96daec64f6b5b10a1c6b02c7264541ea1.tar.xz linux-9c6429d96daec64f6b5b10a1c6b02c7264541ea1.zip | |
Btrfs: fix a comment in inode.c:evict_inode_truncate_pages()
The comment was not correct about the part where it says the endio
callback of the bio might have not yet been called - update it
to mention that by that time the endio callback execution might
still be in progress only.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/inode.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c0b2b6b51b2a..53afda0ef4e3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -4989,8 +4989,9 @@ static void evict_inode_truncate_pages(struct inode *inode) /* * Keep looping until we have no more ranges in the io tree. * We can have ongoing bios started by readpages (called from readahead) - * that didn't get their end io callbacks called yet or they are still - * in progress ((extent_io.c:end_bio_extent_readpage()). This means some + * that have their endio callback (extent_io.c:end_bio_extent_readpage) + * still in progress (unlocked the pages in the bio but did not yet + * unlocked the ranges in the io tree). Therefore this means some * ranges can still be locked and eviction started because before * submitting those bios, which are executed by a separate task (work * queue kthread), inode references (inode->i_count) were not taken |