diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2012-03-14 22:27:52 +0100 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2012-03-14 22:27:52 +0100 |
| commit | 31796ac4e8f0e88f5c10f1ad6dab8f19bebe44a4 (patch) | |
| tree | c9ae9d50b327d9f5e56f689b8dea5fe6f9a2bfc1 /fs | |
| parent | x32: Fix stupid ia32/x32 inversion in the siginfo format (diff) | |
| download | linux-31796ac4e8f0e88f5c10f1ad6dab8f19bebe44a4.tar.xz linux-31796ac4e8f0e88f5c10f1ad6dab8f19bebe44a4.zip | |
x32: Fix alignment fail in struct compat_siginfo
Adding struct _sigchld_x32 caused a misalignment cascade in struct
siginfo, because union _sifields is located on an 4-byte boundary
(8-byte misaligned.)
Adding new fields that are 8-byte aligned caused the intermediate
structures to also be aligned to 8 bytes, thereby adding padding in
unexpected places.
Thus, change s64 to compat_s64 here, which makes it "misaligned on
paper". In reality these fields *are* actually aligned (there are 3
preceeding ints outside the union and 3 inside struct _sigchld_x32),
but because of the intervening union and struct it is not possible for
gcc to avoid padding without breaking the ABI.
Reported-and-tested-by: H. J. Lu <hjl.tools@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Link: http://lkml.kernel.org/r/1329696488-16970-1-git-send-email-hpa@zytor.com
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions