diff options
| author | Jan Kara <jack@suse.cz> | 2016-09-30 07:57:41 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2016-09-30 07:57:41 +0200 |
| commit | 51e8137b82622d8ea22e993d613db568f11c1523 (patch) | |
| tree | c76a6cb27b7ec6ae3e5f9833ca4fdecfba5a9519 /fs | |
| parent | ext4: allow unlocked direct IO when pages are cached (diff) | |
| download | linux-51e8137b82622d8ea22e993d613db568f11c1523.tar.xz linux-51e8137b82622d8ea22e993d613db568f11c1523.zip | |
ext4: remove plugging from ext4_file_write_iter()
do_blockdev_direct_IO() takes care of properly plugging direct IO so
there's no need to plug again inside ext4_file_write_iter().
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext4/file.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 25342c8dd5d6..25f763f2201a 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -92,7 +92,6 @@ static ssize_t ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) { struct inode *inode = file_inode(iocb->ki_filp); - struct blk_plug plug; int o_direct = iocb->ki_flags & IOCB_DIRECT; int unaligned_aio = 0; int overwrite = 0; @@ -133,7 +132,6 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) if (o_direct) { size_t length = iov_iter_count(from); loff_t pos = iocb->ki_pos; - blk_start_plug(&plug); /* check whether we do a DIO overwrite or not */ if (ext4_should_dioread_nolock(inode) && !unaligned_aio && @@ -169,8 +167,6 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) if (ret > 0) ret = generic_write_sync(iocb, ret); - if (o_direct) - blk_finish_plug(&plug); return ret; |