diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2017-07-11 14:58:37 +0200 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2017-07-13 22:06:46 +0200 |
| commit | a59f97ff66f0058702ed6f6e26dd8fa3c34caf62 (patch) | |
| tree | 30046a8c2e3859e7f7a4a4bab2e0fb18a3eb0ceb /fs | |
| parent | ovl: fix origin verification of index dir (diff) | |
| download | linux-a59f97ff66f0058702ed6f6e26dd8fa3c34caf62.tar.xz linux-a59f97ff66f0058702ed6f6e26dd8fa3c34caf62.zip | |
ovl: remove unneeded check for IS_ERR()
ovl_workdir_create() returns a valid index dentry or NULL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/overlayfs/super.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 1cf5d3538309..c88493b01d8d 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -1058,10 +1058,6 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent) ufs->indexdir = ovl_workdir_create(sb, ufs, workpath.dentry, OVL_INDEXDIR_NAME, true); - err = PTR_ERR(ufs->indexdir); - if (IS_ERR(ufs->indexdir)) - goto out_put_lower_mnt; - if (ufs->indexdir) { /* Verify upper root is index dir origin */ err = ovl_verify_origin(ufs->indexdir, ufs->upper_mnt, |