summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorFengguang Wu <fengguang.wu@intel.com>2018-02-05 17:25:16 +0100
committerMiklos Szeredi <mszeredi@redhat.com>2018-02-26 12:45:20 +0100
commitb5095f24e791c2d05da7cbb3d99e2b420b36a273 (patch)
tree45db7f1898ce4925a19d62dfe15644e591b0b8d6 /fs
parentovl: check ERR_PTR() return value from ovl_lookup_real() (diff)
downloadlinux-b5095f24e791c2d05da7cbb3d99e2b420b36a273.tar.xz
linux-b5095f24e791c2d05da7cbb3d99e2b420b36a273.zip
ovl: fix ptr_ret.cocci warnings
fs/overlayfs/export.c:459:10-16: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 4b91c30a5a19 ("ovl: lookup connected ancestor of dir in inode cache") CC: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/overlayfs/export.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/overlayfs/export.c b/fs/overlayfs/export.c
index 97a916ea8b86..87bd4148f4fb 100644
--- a/fs/overlayfs/export.c
+++ b/fs/overlayfs/export.c
@@ -620,7 +620,7 @@ static struct dentry *ovl_lookup_real(struct super_block *sb,
if (err == -ECHILD) {
this = ovl_lookup_real_ancestor(sb, real,
layer);
- err = IS_ERR(this) ? PTR_ERR(this) : 0;
+ err = PTR_ERR_OR_ZERO(this);
}
if (!err) {
dput(connected);