diff options
| author | Benjamin Marzinski <bmarzins@redhat.com> | 2015-05-01 16:36:00 +0200 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2015-05-01 16:36:00 +0200 |
| commit | 086cc672e1cb600b9c17688a4aa44560db858c03 (patch) | |
| tree | 314f310ad31531e19adeaae83e126a80d6a3f7c6 /fs | |
| parent | GFS2: Average in only non-zero round-trip times for congestion stats (diff) | |
| download | linux-086cc672e1cb600b9c17688a4aa44560db858c03.tar.xz linux-086cc672e1cb600b9c17688a4aa44560db858c03.zip | |
GFS2: mark the journal idle to fix ro mounts
When gfs2 was mounted read-only and then unmounted, it was writing a
header block to the journal in the syncing gfs2_log_flush() call from
kill_sb(). This is because the journal was not being marked as idle
until the first log header was written out, and on a read-only mount
there never was a log header written out. Since the journal was not
marked idle, gfs2_log_flush() was writing out a header lock to make
sure it was empty during the sync. Not only did this cause IO to a
read-only filesystem, but the journalling isn't completely initialized
on read-only mounts, and so gfs2 was writing out the wrong sequence
number in the log header.
Now, the journal is marked idle on mount, and gfs2_log_flush() won't
write out anything until there starts being transactions to flush.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/gfs2/ops_fstype.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index efc8e254787c..e4fdeccd50cd 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -756,6 +756,7 @@ static int init_journal(struct gfs2_sbd *sdp, int undo) } } + sdp->sd_log_idle = 1; set_bit(SDF_JOURNAL_CHECKED, &sdp->sd_flags); gfs2_glock_dq_uninit(&ji_gh); jindex = 0; |