diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2011-11-23 18:28:17 +0100 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2011-11-23 18:28:17 +0100 |
| commit | 24b7ead3fb0bae267c2ee50898eb4c13aedd1e9f (patch) | |
| tree | 899a48d29daebb6e2eb9398797304985e5961fc8 /fs | |
| parent | freezer: kill unused set_freezable_with_signal() (diff) | |
| download | linux-24b7ead3fb0bae267c2ee50898eb4c13aedd1e9f.tar.xz linux-24b7ead3fb0bae267c2ee50898eb4c13aedd1e9f.zip | |
freezer: fix wait_event_freezable/__thaw_task races
wait_event_freezable() and friends stop the waiting if try_to_freeze()
fails. This is not right, we can race with __thaw_task() and in this
case
- wait_event_freezable() returns the wrong ERESTARTSYS
- wait_event_freezable_timeout() can return the positive
value while condition == F
Change the code to always check __retval/condition before return.
Note: with or without this patch the timeout logic looks strange,
probably we should recalc timeout if try_to_freeze() returns T.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions