diff options
| author | David Sterba <dsterba@suse.com> | 2017-06-19 14:14:22 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-11-15 14:46:12 +0100 |
| commit | 619c47f3d4cd7a60576fd15e133a2eee4fcc0c4e (patch) | |
| tree | c73056789eb418375d1a590b713b5015779f7764 /fs | |
| parent | btrfs: add missing device::flush_bio puts (diff) | |
| download | linux-619c47f3d4cd7a60576fd15e133a2eee4fcc0c4e.tar.xz linux-619c47f3d4cd7a60576fd15e133a2eee4fcc0c4e.zip | |
btrfs: dev_alloc_list is not protected by RCU, use normal list_del
The dev_alloc_list list could be protected by various mutexes,
depending on the context. The list tracks devices that can take part of
allocating new chunks, so the closest mutex is chunk_mutex. Adding a new
device from inside the ADD_DEV ioctl will need device_list_mutex and
registering a new device from the ioctl needs uuid_mutex.
All mutexes naturally guarantee exclusivity against the same context.
The device ownership can move between the contexts and the exclusivity
is guaranteed by other means, eg. during the mount with the uuid_mutex.
There's no RCU involved for dev_alloc_list.
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/volumes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index b5c67dd5e522..d48b24e54366 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2002,7 +2002,7 @@ void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_fs_info *fs_info, fs_devices = srcdev->fs_devices; list_del_rcu(&srcdev->dev_list); - list_del_rcu(&srcdev->dev_alloc_list); + list_del(&srcdev->dev_alloc_list); fs_devices->num_devices--; if (srcdev->missing) fs_devices->missing_devices--; |