diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2018-07-01 22:57:13 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-07 09:57:10 +0200 |
| commit | 166126c1e54d927c2e8efa2702d420e0ce301fd9 (patch) | |
| tree | 408e4714e20f91e1d32bb005a0e03683067decf3 /fs | |
| parent | device: Add #define dev_fmt similar to #define pr_fmt (diff) | |
| download | linux-166126c1e54d927c2e8efa2702d420e0ce301fd9.tar.xz linux-166126c1e54d927c2e8efa2702d420e0ce301fd9.zip | |
kernfs: Replace strncpy with memcpy
gcc 8.1.0 complains:
fs/kernfs/symlink.c:91:3: warning:
'strncpy' output truncated before terminating nul copying
as many bytes from a string as its length
fs/kernfs/symlink.c: In function 'kernfs_iop_get_link':
fs/kernfs/symlink.c:88:14: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/kernfs/symlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/kernfs/symlink.c b/fs/kernfs/symlink.c index 08ccabd7047f..5145ae2f0572 100644 --- a/fs/kernfs/symlink.c +++ b/fs/kernfs/symlink.c @@ -88,7 +88,7 @@ static int kernfs_get_target_path(struct kernfs_node *parent, int slen = strlen(kn->name); len -= slen; - strncpy(s + len, kn->name, slen); + memcpy(s + len, kn->name, slen); if (len) s[--len] = '/'; |