diff options
| author | David Sterba <dsterba@suse.com> | 2021-01-08 17:06:10 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-01-12 15:35:04 +0100 |
| commit | 14ff8e1970c03831bf64cf098f56e6ba83349170 (patch) | |
| tree | 4be7c81c7ac2b4af5c1d6109fd1997ce36c0c089 /fs | |
| parent | btrfs: shrink delalloc pages instead of full inodes (diff) | |
| download | linux-14ff8e1970c03831bf64cf098f56e6ba83349170.tar.xz linux-14ff8e1970c03831bf64cf098f56e6ba83349170.zip | |
btrfs: no need to run delayed refs after commit_fs_roots during commit
The inode number cache has been removed in this dev cycle, there's one
more leftover. We don't need to run the delayed refs again after
commit_fs_roots as stated in the comment, because btrfs_save_ino_cache
is no more since 5297199a8bca ("btrfs: remove inode number cache
feature").
Nothing else between commit_fs_roots and btrfs_qgroup_account_extents
could create new delayed refs so the qgroup consistency should be safe.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/transaction.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 8e0f7a1029c6..6af7f2bf92de 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -2265,14 +2265,6 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans) btrfs_free_log_root_tree(trans, fs_info); /* - * commit_fs_roots() can call btrfs_save_ino_cache(), which generates - * new delayed refs. Must handle them or qgroup can be wrong. - */ - ret = btrfs_run_delayed_refs(trans, (unsigned long)-1); - if (ret) - goto unlock_tree_log; - - /* * Since fs roots are all committed, we can get a quite accurate * new_roots. So let's do quota accounting. */ |