diff options
| author | Zhang Xiaoxu <zhangxiaoxu5@huawei.com> | 2022-10-17 16:45:21 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-10-18 18:33:43 +0200 |
| commit | fee0fb1f15054bb6a0ede452acb42da5bef4d587 (patch) | |
| tree | f8ad43387369c2251f6c90f5bccfce77b38cee00 /fs | |
| parent | Linux 6.1-rc1 (diff) | |
| download | linux-fee0fb1f15054bb6a0ede452acb42da5bef4d587.tar.xz linux-fee0fb1f15054bb6a0ede452acb42da5bef4d587.zip | |
cifs: Fix xid leak in cifs_create()
If the cifs already shutdown, we should free the xid before return,
otherwise, the xid will be leaked.
Fixes: 087f757b0129 ("cifs: add shutdown support")
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/dir.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index a5c73c2af3a2..8b1c37158556 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -543,8 +543,10 @@ int cifs_create(struct user_namespace *mnt_userns, struct inode *inode, cifs_dbg(FYI, "cifs_create parent inode = 0x%p name is: %pd and dentry = 0x%p\n", inode, direntry, direntry); - if (unlikely(cifs_forced_shutdown(CIFS_SB(inode->i_sb)))) - return -EIO; + if (unlikely(cifs_forced_shutdown(CIFS_SB(inode->i_sb)))) { + rc = -EIO; + goto out_free_xid; + } tlink = cifs_sb_tlink(CIFS_SB(inode->i_sb)); rc = PTR_ERR(tlink); |