diff options
| author | Pankaj Raghav <p.raghav@samsung.com> | 2022-03-22 10:20:48 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2022-03-23 09:19:17 +0100 |
| commit | 726be2c72efc0a64c206e854b8996ad3ab9c7507 (patch) | |
| tree | 6c5531969fc116be38f705fef287a52027f1d282 /fs | |
| parent | n64cart: convert bi_disk to bi_bdev->bd_disk fix build (diff) | |
| download | linux-726be2c72efc0a64c206e854b8996ad3ab9c7507.tar.xz linux-726be2c72efc0a64c206e854b8996ad3ab9c7507.zip | |
nvme: fix the read-only state for zoned namespaces with unsupposed features
commit 2f4c9ba23b88 ("nvme: export zoned namespaces without Zone Append
support read-only") marks zoned namespaces without append support
read-only. It does iso by setting NVME_NS_FORCE_RO in ns->flags in
nvme_update_zone_info and checking for that flag later in
nvme_update_disk_info to mark the disk as read-only.
But commit 73d90386b559 ("nvme: cleanup zone information initialization")
rearranged nvme_update_disk_info to be called before
nvme_update_zone_info and thus not marking the disk as read-only.
The call order cannot be just reverted because nvme_update_zone_info sets
certain queue parameters such as zone_write_granularity that depend on the
prior call to nvme_update_disk_info.
Remove the call to set_disk_ro in nvme_update_disk_info. and call
set_disk_ro after nvme_update_zone_info and nvme_update_disk_info to set
the permission for ZNS drives correctly. The same applies to the
multipath disk path.
Fixes: 73d90386b559 ("nvme: cleanup zone information initialization")
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions