diff options
| author | Jan Kara <jack@suse.cz> | 2022-01-18 09:57:25 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2022-01-24 14:45:02 +0100 |
| commit | ea8569194b43f0f01f0a84c689388542c7254a1f (patch) | |
| tree | bdabba9ed18aab1a83dfbef27495b955d42fbac6 /fs | |
| parent | udf: Fix NULL ptr deref when converting from inline format (diff) | |
| download | linux-ea8569194b43f0f01f0a84c689388542c7254a1f.tar.xz linux-ea8569194b43f0f01f0a84c689388542c7254a1f.zip | |
udf: Restore i_lenAlloc when inode expansion fails
When we fail to expand inode from inline format to a normal format, we
restore inode to contain the original inline formatting but we forgot to
set i_lenAlloc back. The mismatch between i_lenAlloc and i_size was then
causing further problems such as warnings and lost data down the line.
Reported-by: butt3rflyh4ck <butterflyhuangxx@gmail.com>
CC: stable@vger.kernel.org
Fixes: 7e49b6f2480c ("udf: Convert UDF to new truncate calling sequence")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/udf/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index d6aa506b6b58..ea8f6cd01f50 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -315,6 +315,7 @@ int udf_expand_file_adinicb(struct inode *inode) unlock_page(page); iinfo->i_alloc_type = ICBTAG_FLAG_AD_IN_ICB; inode->i_data.a_ops = &udf_adinicb_aops; + iinfo->i_lenAlloc = inode->i_size; up_write(&iinfo->i_data_sem); } put_page(page); |