summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorKaixu Xia <kaixuxia@tencent.com>2020-04-23 06:54:29 +0200
committerDarrick J. Wong <darrick.wong@oracle.com>2020-05-04 18:03:14 +0200
commit7994aae8516aa35ca26dba64cf8d6938e93c2265 (patch)
tree40144457c53c0657aa1f85b0a74c201a048d4526 /fs
parentxfs: remove unnecessary variable udqp from xfs_ioctl_setattr (diff)
downloadlinux-7994aae8516aa35ca26dba64cf8d6938e93c2265.tar.xz
linux-7994aae8516aa35ca26dba64cf8d6938e93c2265.zip
xfs: remove unnecessary assertion from xfs_qm_vop_create_dqattach
The check XFS_IS_QUOTA_RUNNING() has been done when enter the xfs_qm_vop_create_dqattach() function, it will return directly if the result is false, so the followed XFS_IS_QUOTA_RUNNING() assertion is unnecessary. If we truly care about this, the check also can be added to the condition of next if statements. Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/xfs/xfs_qm.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index b684b0410a52..fc93f88a9926 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -1932,7 +1932,6 @@ xfs_qm_vop_create_dqattach(
return;
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
- ASSERT(XFS_IS_QUOTA_RUNNING(mp));
if (udqp && XFS_IS_UQUOTA_ON(mp)) {
ASSERT(ip->i_udquot == NULL);