diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2021-08-30 22:30:45 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2021-08-31 23:39:39 +0200 |
| commit | 9605f75cf36e0bcc0f4ada07b5be712d30107607 (patch) | |
| tree | c1a8812191b839f0e5a1daab2ce71ccb911bb1a9 /fs | |
| parent | f2fs: deallocate compressed pages when error happens (diff) | |
| download | linux-9605f75cf36e0bcc0f4ada07b5be712d30107607.tar.xz linux-9605f75cf36e0bcc0f4ada07b5be712d30107607.zip | |
f2fs: should put a page beyond EOF when preparing a write
The prepare_compress_overwrite() gets/locks a page to prepare a read, and calls
f2fs_read_multi_pages() which checks EOF first. If there's any page beyond EOF,
we unlock the page and set cc->rpages[i] = NULL, which we can't put the page
anymore. This makes page leak, so let's fix by putting that page.
Fixes: a949dc5f2c5c ("f2fs: compress: fix race condition of overwrite vs truncate")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/data.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 8e8824605f83..41d29382eced 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2183,6 +2183,8 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, continue; } unlock_page(page); + if (for_write) + put_page(page); cc->rpages[i] = NULL; cc->nr_rpages--; } |