diff options
| author | Jeff Mahoney <jeffm@suse.com> | 2014-04-02 20:40:26 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2014-04-03 00:06:14 +0200 |
| commit | 01d8885785a60ae8f4c37b0ed75bdc96d0fc6a44 (patch) | |
| tree | 212ac3940dc154fc2cffe0917c18e15e6e685ee3 /fs | |
| parent | ext2: acl: remove unneeded include of linux/capability.h (diff) | |
| download | linux-01d8885785a60ae8f4c37b0ed75bdc96d0fc6a44.tar.xz linux-01d8885785a60ae8f4c37b0ed75bdc96d0fc6a44.zip | |
reiserfs: fix race in readdir
jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-2)
The -ENOENT is due to readdir calling dir_emit on the same entry twice.
If the dir_emit callback sleeps and the tree is changed underneath us,
we won't be able to trust deh_offset(deh) anymore. We need to save
next_pos before we might sleep so we can find the next entry.
CC: stable@vger.kernel.org
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/reiserfs/dir.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c index 1fd2051109a3..af677353a3f5 100644 --- a/fs/reiserfs/dir.c +++ b/fs/reiserfs/dir.c @@ -125,6 +125,7 @@ int reiserfs_readdir_inode(struct inode *inode, struct dir_context *ctx) int d_reclen; char *d_name; ino_t d_ino; + loff_t cur_pos = deh_offset(deh); if (!de_visible(deh)) /* it is hidden entry */ @@ -196,8 +197,9 @@ int reiserfs_readdir_inode(struct inode *inode, struct dir_context *ctx) if (local_buf != small_buf) { kfree(local_buf); } - // next entry should be looked for with such offset - next_pos = deh_offset(deh) + 1; + + /* deh_offset(deh) may be invalid now. */ + next_pos = cur_pos + 1; if (item_moved(&tmp_ih, &path_to_entry)) { set_cpu_key_k_offset(&pos_key, |