summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMårten Lindahl <marten.lindahl@axis.com>2023-03-30 11:32:14 +0200
committerRichard Weinberger <richard@nod.at>2023-04-21 22:37:37 +0200
commit1fb815b38bb31d6af9bd0540b8652a0d6fe6cfd3 (patch)
tree6e9e1db54c4342b53ddce0e1d8a0cdc6824e6d47 /fs
parentubi: Fix return value overwrite issue in try_write_vid_and_data() (diff)
downloadlinux-1fb815b38bb31d6af9bd0540b8652a0d6fe6cfd3.tar.xz
linux-1fb815b38bb31d6af9bd0540b8652a0d6fe6cfd3.zip
ubifs: Free memory for tmpfile name
When opening a ubifs tmpfile on an encrypted directory, function fscrypt_setup_filename allocates memory for the name that is to be stored in the directory entry, but after the name has been copied to the directory entry inode, the memory is not freed. When running kmemleak on it we see that it is registered as a leak. The report below is triggered by a simple program 'tmpfile' just opening a tmpfile: unreferenced object 0xffff88810178f380 (size 32): comm "tmpfile", pid 509, jiffies 4294934744 (age 1524.742s) backtrace: __kmem_cache_alloc_node __kmalloc fscrypt_setup_filename ubifs_tmpfile vfs_tmpfile path_openat Free this memory after it has been copied to the inode. Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> Cc: stable@vger.kernel.org Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs')
-rw-r--r--fs/ubifs/dir.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 1505539f6fe9..5f33dbad27f6 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -492,6 +492,7 @@ static int ubifs_tmpfile(struct mnt_idmap *idmap, struct inode *dir,
unlock_2_inodes(dir, inode);
ubifs_release_budget(c, &req);
+ fscrypt_free_filename(&nm);
return finish_open_simple(file, 0);