diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2024-01-15 02:24:54 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-01-15 05:14:56 +0100 |
| commit | 77bebd186442a7d703b796784db7495129cc3e70 (patch) | |
| tree | c2c0e0ef6d40f4fe0be2fcbc6f3e64b2d939e19c /fs | |
| parent | ksmbd: fix UAF issue in ksmbd_tcp_new_connection() (diff) | |
| download | linux-77bebd186442a7d703b796784db7495129cc3e70.tar.xz linux-77bebd186442a7d703b796784db7495129cc3e70.zip | |
ksmbd: only v2 leases handle the directory
When smb2 leases is disable, ksmbd can send oplock break notification
and cause wait oplock break ack timeout. It may appear like hang when
accessing a directory. This patch make only v2 leases handle the
directory.
Cc: stable@vger.kernel.org
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/oplock.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/smb/server/oplock.c b/fs/smb/server/oplock.c index 001926d3b348..53dfaac425c6 100644 --- a/fs/smb/server/oplock.c +++ b/fs/smb/server/oplock.c @@ -1197,6 +1197,12 @@ int smb_grant_oplock(struct ksmbd_work *work, int req_op_level, u64 pid, bool prev_op_has_lease; __le32 prev_op_state = 0; + /* Only v2 leases handle the directory */ + if (S_ISDIR(file_inode(fp->filp)->i_mode)) { + if (!lctx || lctx->version != 2) + return 0; + } + opinfo = alloc_opinfo(work, pid, tid); if (!opinfo) return -ENOMEM; |