summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2023-12-20 06:20:54 +0100
committerIlya Dryomov <idryomov@gmail.com>2024-01-15 15:40:51 +0100
commitf6fb21b22fbe443f92b0d580391a7fb46d1840df (patch)
tree583c74f98bef7a2f5d327cab4b46800ae8005cc9 /fs
parentceph: fix invalid pointer access if get_quota_realm return ERR_PTR (diff)
downloadlinux-f6fb21b22fbe443f92b0d580391a7fb46d1840df.tar.xz
linux-f6fb21b22fbe443f92b0d580391a7fb46d1840df.zip
ceph: d_obtain_{alias,root}(ERR_PTR(...)) will do the right thing
Clean up the code. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Reviewed-by: Xiubo Li <xiubli@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/ceph/export.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ceph/export.c b/fs/ceph/export.c
index 726af69d4d62..a79f163ae4ed 100644
--- a/fs/ceph/export.c
+++ b/fs/ceph/export.c
@@ -286,8 +286,6 @@ static struct dentry *__snapfh_to_dentry(struct super_block *sb,
doutc(cl, "%llx.%llx parent %llx hash %x err=%d", vino.ino,
vino.snap, sfh->parent_ino, sfh->hash, err);
}
- if (IS_ERR(inode))
- return ERR_CAST(inode);
/* see comments in ceph_get_parent() */
return unlinked ? d_obtain_root(inode) : d_obtain_alias(inode);
}