summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@linux.dev>2024-09-28 03:05:59 +0200
committerKent Overstreet <kent.overstreet@linux.dev>2024-09-28 04:32:22 +0200
commit9773547b16b1e1b27f002733623cd0e8e6d0f69c (patch)
tree88f55796965cf434828b449b7c2537ae072336e3 /fs
parentbcachefs: Fix BCH_TRANS_COMMIT_skip_accounting_apply (diff)
downloadlinux-9773547b16b1e1b27f002733623cd0e8e6d0f69c.tar.xz
linux-9773547b16b1e1b27f002733623cd0e8e6d0f69c.zip
bcachefs: Convert disk accounting BUG_ON() to WARN_ON()
We had a bug where disk accounting keys didn't always have their version field set in journal replay; change the BUG_ON() to a WARN(), and exclude this case since it's now checked for elsewhere (in the bkey validate function). Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs')
-rw-r--r--fs/bcachefs/disk_accounting.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/disk_accounting.c b/fs/bcachefs/disk_accounting.c
index 59897b347c62..9f3133e3e7e5 100644
--- a/fs/bcachefs/disk_accounting.c
+++ b/fs/bcachefs/disk_accounting.c
@@ -648,7 +648,7 @@ int bch2_accounting_read(struct bch_fs *c)
if (i + 1 < &darray_top(*keys) &&
i[1].k->k.type == KEY_TYPE_accounting &&
!journal_key_cmp(i, i + 1)) {
- BUG_ON(bversion_cmp(i[0].k->k.bversion, i[1].k->k.bversion) >= 0);
+ WARN_ON(bversion_cmp(i[0].k->k.bversion, i[1].k->k.bversion) >= 0);
i[1].journal_seq = i[0].journal_seq;