summaryrefslogtreecommitdiffstats
path: root/include/acpi
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2012-08-26 20:44:43 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2012-09-06 17:11:53 +0200
commit1f1ea6c2d9d8c0be9ec56454b05315273b5de8ce (patch)
tree4718cdc2e494f18ab13c2c8f09930953b77c31ff /include/acpi
parentNFSv4: Fix range checking in __nfs4_get_acl_uncached and __nfs4_proc_set_acl (diff)
downloadlinux-1f1ea6c2d9d8c0be9ec56454b05315273b5de8ce.tar.xz
linux-1f1ea6c2d9d8c0be9ec56454b05315273b5de8ce.zip
NFSv4: Fix buffer overflow checking in __nfs4_get_acl_uncached
Pass the checks made by decode_getacl back to __nfs4_get_acl_uncached so that it knows if the acl has been truncated. The current overflow checking is broken, resulting in Oopses on user-triggered nfs4_getfacl calls, and is opaque to the point where several attempts at fixing it have failed. This patch tries to clean up the code in addition to fixing the Oopses by ensuring that the overflow checks are performed in a single place (decode_getacl). If the overflow check failed, we will still be able to report the acl length, but at least we will no longer attempt to cache the acl or copy the truncated contents to user space. Reported-by: Sachin Prabhu <sprabhu@redhat.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Tested-by: Sachin Prabhu <sprabhu@redhat.com>
Diffstat (limited to 'include/acpi')
0 files changed, 0 insertions, 0 deletions