summaryrefslogtreecommitdiffstats
path: root/include/drm/gma_drm.h
diff options
context:
space:
mode:
authorEric Engestrom <eric@engestrom.ch>2016-11-12 02:12:56 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2016-11-12 14:19:38 +0100
commitb3c11ac267d461d3d597967164ff7278a919a39f (patch)
treeb493960fb72de73ef4a7b202bd0bc96b11340f2a /include/drm/gma_drm.h
parentdrm: Add missing mutex_destroy in drm_dev_init/release (diff)
downloadlinux-b3c11ac267d461d3d597967164ff7278a919a39f.tar.xz
linux-b3c11ac267d461d3d597967164ff7278a919a39f.zip
drm: move allocation out of drm_get_format_name()
The function's behaviour was changed in 90844f00049e, without changing its signature, causing people to keep using it the old way without realising they were now leaking memory. Rob Clark also noticed it was also allocating GFP_KERNEL memory in atomic contexts, breaking them. Instead of having to allocate GFP_ATOMIC memory and fixing the callers to make them cleanup the memory afterwards, let's change the function's signature by having the caller take care of the memory and passing it to the function. The new parameter is a single-field struct in order to enforce the size of its buffer and help callers to correctly manage their memory. Fixes: 90844f00049e ("drm: make drm_get_format_name thread-safe") Cc: Rob Clark <robdclark@gmail.com> Cc: Christian König <christian.koenig@amd.com> Acked-by: Christian König <christian.koenig@amd.com> Acked-by: Rob Clark <robdclark@gmail.com> Acked-by: Sinclair Yeh <syeh@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nikula@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Eric Engestrom <eric@engestrom.ch> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/20161112011309.9799-1-eric@engestrom.ch
Diffstat (limited to 'include/drm/gma_drm.h')
0 files changed, 0 insertions, 0 deletions