diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2022-01-24 19:46:50 +0100 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2022-01-27 01:34:11 +0100 |
commit | f9d87929d451d3e649699d0f1d74f71f77ad38f5 (patch) | |
tree | 89237016732d74ce6b40294164c716e5723fd4e3 /include/keys/system_keyring.h | |
parent | Linux 5.17-rc1 (diff) | |
download | linux-f9d87929d451d3e649699d0f1d74f71f77ad38f5.tar.xz linux-f9d87929d451d3e649699d0f1d74f71f77ad38f5.zip |
ucount: Make get_ucount a safe get_user replacement
When the ucount code was refactored to create get_ucount it was missed
that some of the contexts in which a rlimit is kept elevated can be
the only reference to the user/ucount in the system.
Ordinary ucount references exist in places that also have a reference
to the user namspace, but in POSIX message queues, the SysV shm code,
and the SIGPENDING code there is no independent user namespace
reference.
Inspection of the the user_namespace show no instance of circular
references between struct ucounts and the user_namespace. So
hold a reference from struct ucount to i's user_namespace to
resolve this problem.
Link: https://lore.kernel.org/lkml/YZV7Z+yXbsx9p3JN@fixkernel.com/
Reported-by: Qian Cai <quic_qiancai@quicinc.com>
Reported-by: Mathias Krause <minipli@grsecurity.net>
Tested-by: Mathias Krause <minipli@grsecurity.net>
Reviewed-by: Mathias Krause <minipli@grsecurity.net>
Reviewed-by: Alexey Gladkov <legion@kernel.org>
Fixes: d64696905554 ("Reimplement RLIMIT_SIGPENDING on top of ucounts")
Fixes: 6e52a9f0532f ("Reimplement RLIMIT_MSGQUEUE on top of ucounts")
Fixes: d7c9e99aee48 ("Reimplement RLIMIT_MEMLOCK on top of ucounts")
Cc: stable@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'include/keys/system_keyring.h')
0 files changed, 0 insertions, 0 deletions