diff options
author | Willem de Bruijn <willemb@google.com> | 2018-05-25 00:10:30 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-05-25 03:55:20 +0200 |
commit | 9aad13b087ab0a588cd68259de618f100053360e (patch) | |
tree | 3b8aa031c4bbfe2fe07021e9aa7de0805c63e926 /include/media/dvbdev.h | |
parent | net/mlx4: Fix irq-unsafe spinlock usage (diff) | |
download | linux-9aad13b087ab0a588cd68259de618f100053360e.tar.xz linux-9aad13b087ab0a588cd68259de618f100053360e.zip |
packet: fix reserve calculation
Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link
layer allocation") ensures that packet_snd always starts writing
the link layer header in reserved headroom allocated for this
purpose.
This is needed because packets may be shorter than hard_header_len,
in which case the space up to hard_header_len may be zeroed. But
that necessary padding is not accounted for in skb->len.
The fix, however, is buggy. It calls skb_push, which grows skb->len
when moving skb->data back. But in this case packet length should not
change.
Instead, call skb_reserve, which moves both skb->data and skb->tail
back, without changing length.
Fixes: b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation")
Reported-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/media/dvbdev.h')
0 files changed, 0 insertions, 0 deletions