summaryrefslogtreecommitdiffstats
path: root/include/media
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-07-19 11:58:20 +0200
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-07-26 14:26:21 +0200
commit8033120f36c0b7212825f621a54e2d0f5ce72f72 (patch)
tree04f8e515f1fd16bc7dfc88a700a7b6e601840bb0 /include/media
parentmedia: atomisp2: array underflow in ap1302_enum_frame_size() (diff)
downloadlinux-8033120f36c0b7212825f621a54e2d0f5ce72f72.tar.xz
linux-8033120f36c0b7212825f621a54e2d0f5ce72f72.zip
media: atomisp2: array underflow in imx_enum_frame_size()
The code looks in imx_enum_frame_size() looks like this: 2066 int index = fse->index; 2067 struct imx_device *dev = to_imx_sensor(sd); 2068 2069 mutex_lock(&dev->input_lock); 2070 if (index >= dev->entries_curr_table) { 2071 mutex_unlock(&dev->input_lock); 2072 return -EINVAL; 2073 } 2074 2075 fse->min_width = dev->curr_res_table[index].width; "fse->index" is a u32 that comes from the user. We want negative values of "index" to be -EINVAL so we don't read before the start of the dev->curr_res_table[] array. I've made "entries_curr_table" unsigned long to fix this. I thought about making it unsigned int, but because of struct alignment, it doesn't use more memory either way. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'include/media')
0 files changed, 0 insertions, 0 deletions