diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-03-21 17:00:55 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-05-18 05:52:58 +0200 |
| commit | 9f1547829a6f39fe6b2da22653dff40502f3d568 (patch) | |
| tree | 71c200ea5be13eef6b96f8e2290f0d2ba7792a09 /include/media | |
| parent | V4L/DVB: ir-core/saa7134: Move ir keyup/keydown code to the ir-core (diff) | |
| download | linux-9f1547829a6f39fe6b2da22653dff40502f3d568.tar.xz linux-9f1547829a6f39fe6b2da22653dff40502f3d568.zip | |
V4L/DVB: saa7134: don't wait too much to generate an IR event on raw_decode
At raw_decode mode, the key is processed after the end of a timer. The
previous code resets the timer every time something is received at the IR
port. While this works fine with IR's that don't implement repeat, like
Avermedia RM-JX IR, it keeps waiting until keydown, on IR's that implement
NEC repeat command, like the Terratec yellow.
The solution is to change the behaviour to do the timeout after the first
received data.
The timeout is currently set to 15 ms, as it works fine with NEC protcocol.
It may need some adjustments to support other protocols and to better handle
spurious detections that may happen with some IR sensors.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'include/media')
| -rw-r--r-- | include/media/ir-core.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/media/ir-core.h b/include/media/ir-core.h index 9e03528a767a..8d8ed7e06cd5 100644 --- a/include/media/ir-core.h +++ b/include/media/ir-core.h @@ -18,6 +18,7 @@ #include <linux/spinlock.h> #include <linux/kfifo.h> #include <linux/time.h> +#include <linux/timer.h> extern int ir_core_debug; #define IR_dprintk(level, fmt, arg...) if (ir_core_debug >= level) \ @@ -63,6 +64,7 @@ struct ir_raw_event { struct ir_raw_event_ctrl { struct kfifo kfifo; /* fifo for the pulse/space events */ struct timespec last_event; /* when last event occurred */ + struct timer_list timer_keyup; /* timer for key release */ }; struct ir_input_dev { |