diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2018-02-19 03:39:17 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-21 20:14:04 +0100 |
| commit | 646fe03b0d5fb678f0901e25eb184ae8860744fa (patch) | |
| tree | 18f8bb2053912c4743b226d55672c9568704ebdf /include/net/Space.h | |
| parent | net/8390: Remove redundant make dependencies (diff) | |
| download | linux-646fe03b0d5fb678f0901e25eb184ae8860744fa.tar.xz linux-646fe03b0d5fb678f0901e25eb184ae8860744fa.zip | |
net/8390: Fix msg_enable patch snafu
The lib8390 module parameter 'msg_enable' doesn't do anything useful:
it causes an ancient version string to be logged.
Remove redundant code that logs the same string.
In ne.c and wd.c, the value of ei_local->msg_enable is used before
being assigned. Use ne_msg_enable and wd_msg_enable, respectively.
Most of the other 8390 drivers never assign ei_local->msg_enable.
Use the 'msg_enable' module parameter from lib8390 as the default
value.
Eliminate the pointless static and local variables.
Clean up an indentation mistake.
All of these issues originated from the same patch.
Cc: Russell King <linux@armlinux.org.uk>
Fixes: c45f812f0280 ("8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/Space.h')
0 files changed, 0 insertions, 0 deletions