summaryrefslogtreecommitdiffstats
path: root/include/net/codel_impl.h
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2021-12-21 20:39:40 +0100
committerJakub Kicinski <kuba@kernel.org>2021-12-23 00:03:47 +0100
commit15fcb1031178f2a42425c2993b2ec7bb894c04d6 (patch)
tree150c98c5e6f0544019b608d6fbb61d34041a4d06 /include/net/codel_impl.h
parentnet: broadcom: bcm4908enet: remove redundant variable bytes (diff)
downloadlinux-15fcb1031178f2a42425c2993b2ec7bb894c04d6.tar.xz
linux-15fcb1031178f2a42425c2993b2ec7bb894c04d6.zip
codel: remove unnecessary sock.h include
Since sock.h is modified relatively often (60 times in the last 12 months) it seems worthwhile to decrease the incremental build work. CoDel's header includes net/inet_ecn.h which in turn includes net/sock.h. codel.h is itself included by mac80211 which is included by much of the WiFi stack and drivers. Removing the net/inet_ecn.h include from CoDel breaks the dependecy between WiFi and sock.h. Commit d068ca2ae2e6 ("codel: split into multiple files") moved all the code which actually needs ECN helpers out to net/codel_impl.h, the include can be moved there as well. This decreases the incremental build size after touching sock.h from 4999 objects to 4051 objects. Fix unmasked missing includes in WiFi drivers. Acked-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20211221193941.3805147-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net/codel_impl.h')
-rw-r--r--include/net/codel_impl.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/net/codel_impl.h b/include/net/codel_impl.h
index 137d40d8cbeb..78a27ac73070 100644
--- a/include/net/codel_impl.h
+++ b/include/net/codel_impl.h
@@ -49,6 +49,8 @@
* Implemented on linux by Dave Taht and Eric Dumazet
*/
+#include <net/inet_ecn.h>
+
static void codel_params_init(struct codel_params *params)
{
params->interval = MS2TIME(100);