summaryrefslogtreecommitdiffstats
path: root/include/net/devlink.h
diff options
context:
space:
mode:
authorJiri Pirko <jiri@nvidia.com>2023-05-26 12:28:40 +0200
committerJakub Kicinski <kuba@kernel.org>2023-05-30 19:32:20 +0200
commit216ba9f4adc8f2e452edb9a58d2dfbfc11608c00 (patch)
tree047ff2829d2e6fda1d1c4efcbdb2278636794b31 /include/net/devlink.h
parentdevlink: move port_fn_state_get/set() to devlink_port_ops (diff)
downloadlinux-216ba9f4adc8f2e452edb9a58d2dfbfc11608c00.tar.xz
linux-216ba9f4adc8f2e452edb9a58d2dfbfc11608c00.zip
devlink: move port_del() to devlink_port_ops
Move port_del() from devlink_ops into newly introduced devlink_port_ops. Signed-off-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net/devlink.h')
-rw-r--r--include/net/devlink.h22
1 files changed, 5 insertions, 17 deletions
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 835989c10395..fe42ad46cf3b 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -1447,23 +1447,6 @@ struct devlink_ops {
int (*port_new)(struct devlink *devlink,
const struct devlink_port_new_attrs *attrs,
struct netlink_ext_ack *extack);
- /**
- * port_del() - Delete a port function
- * @devlink: Devlink instance
- * @port: The devlink port
- * @extack: extack for reporting error messages
- *
- * Devlink core will call this device driver function upon user request
- * to delete a previously created port function
- *
- * Notes:
- * - On success, drivers must unregister the corresponding devlink
- * port
- *
- * Return: 0 on success, negative value otherwise.
- */
- int (*port_del)(struct devlink *devlink, struct devlink_port *port,
- struct netlink_ext_ack *extack);
/**
* Rate control callbacks.
@@ -1560,6 +1543,9 @@ void devlink_free(struct devlink *devlink);
* @port_unsplit: Callback used to unsplit the port group back into
* a single port.
* @port_type_set: Callback used to set a type of a port.
+ * @port_del: Callback used to delete selected port along with related function.
+ * Devlink core calls this upon user request to delete
+ * a port previously created by devlink_ops->port_new().
* @port_fn_hw_addr_get: Callback used to set port function's hardware address.
* Should be used by device drivers to report
* the hardware address of a function managed
@@ -1602,6 +1588,8 @@ struct devlink_port_ops {
struct netlink_ext_ack *extack);
int (*port_type_set)(struct devlink_port *devlink_port,
enum devlink_port_type port_type);
+ int (*port_del)(struct devlink *devlink, struct devlink_port *port,
+ struct netlink_ext_ack *extack);
int (*port_fn_hw_addr_get)(struct devlink_port *port, u8 *hw_addr,
int *hw_addr_len,
struct netlink_ext_ack *extack);