diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-09-22 23:42:51 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2008-09-24 15:45:48 +0200 |
| commit | 5a51b713ccf8835d5adf7217e2f86eb12b1ca851 (patch) | |
| tree | b5c67c0252bcbd5d8df9b10e9fd306d79e53e8b1 /include/net/dn_route.h | |
| parent | posix-timers: kill ->it_sigev_signo and ->it_sigev_value (diff) | |
| download | linux-5a51b713ccf8835d5adf7217e2f86eb12b1ca851.tar.xz linux-5a51b713ccf8835d5adf7217e2f86eb12b1ca851.zip | |
posix-timers: lock_timer: kill the bogus ->it_id check
lock_timer() checks that the timer found by idr_find(timer_id) has ->it_id
== timer_id. This buys nothing. This check can fail only if
sys_timer_create() unlocked idr_lock after idr_get_new(), but didn't set
->it_id = new_timer_id yet. But in that case ->it_process == NULL so
lock_timer() can't succeed anyway.
Also remove a couple of unneeded typecasts.
Note that with or without this patch we have a small problem.
sys_timer_create() doesn't ensure that the result of setting (say)
->it_sigev_notify must be visible if lock_timer() succeeds.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: mingo@elte.hu
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'include/net/dn_route.h')
0 files changed, 0 insertions, 0 deletions