diff options
author | Maxime Ripard <maxime@cerno.tech> | 2022-10-18 15:52:56 +0200 |
---|---|---|
committer | Stephen Boyd <sboyd@kernel.org> | 2022-10-28 02:06:50 +0200 |
commit | 08a32902a56e1670850fe5d518d8203e9ce354b8 (patch) | |
tree | 44b94d2b23b2d1b8b17e8dc006cf0c148aa62490 /include/net/icmp.h | |
parent | Merge tag 'renesas-clk-fixes-for-v6.1-tag1' of git://git.kernel.org/pub/scm/l... (diff) | |
download | linux-08a32902a56e1670850fe5d518d8203e9ce354b8.tar.xz linux-08a32902a56e1670850fe5d518d8203e9ce354b8.zip |
clk: Remove WARN_ON NULL parent in clk_core_init_rate_req()
If a clock has CLK_SET_RATE_PARENT, but core->parent is NULL (most
likely because it's orphan), callers of clk_core_init_rate_req() will
blindly call this function leading to a very verbose warning.
Since it's a fairly common situation, let's just remove the WARN_ON but
keep the check that prevents us from dereferencing the pointer.
Interestingly, it fixes a regression on the Mediatek MT8195 where the
GPU would stall during a clk_set_rate for its main clock. We couldn't
come up with a proper explanation since the condition is essentially the
same.
It was then assumed that it could be timing related since printing the
warning stacktrace takes a while, but we couldn't replicate the failure
by using fairly large (10ms) mdelays.
Fixes: 262ca38f4b6e ("clk: Stop forwarding clk_rate_requests to the parent")
Reported-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v1-1-f3ef80518140@cerno.tech
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'include/net/icmp.h')
0 files changed, 0 insertions, 0 deletions