diff options
| author | Eric Dumazet <edumazet@google.com> | 2012-06-05 05:00:18 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-06-06 19:45:15 +0200 |
| commit | 55432d2b543a4b6dfae54f5c432a566877a85d90 (patch) | |
| tree | f830eb5150e38be149fcfce74f68716f5bf2641a /include/net/inetpeer.h | |
| parent | net: sierra_net: device IDs for Aircard 320U++ (diff) | |
| download | linux-55432d2b543a4b6dfae54f5c432a566877a85d90.tar.xz linux-55432d2b543a4b6dfae54f5c432a566877a85d90.zip | |
inetpeer: fix a race in inetpeer_gc_worker()
commit 5faa5df1fa2024 (inetpeer: Invalidate the inetpeer tree along with
the routing cache) added a race :
Before freeing an inetpeer, we must respect a RCU grace period, and make
sure no user will attempt to increase refcnt.
inetpeer_invalidate_tree() waits for a RCU grace period before inserting
inetpeer tree into gc_list and waking the worker. At that time, no
concurrent lookup can find a inetpeer in this tree.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/inetpeer.h')
| -rw-r--r-- | include/net/inetpeer.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/net/inetpeer.h b/include/net/inetpeer.h index b94765e38e80..2040bff945d4 100644 --- a/include/net/inetpeer.h +++ b/include/net/inetpeer.h @@ -40,7 +40,10 @@ struct inet_peer { u32 pmtu_orig; u32 pmtu_learned; struct inetpeer_addr_base redirect_learned; - struct list_head gc_list; + union { + struct list_head gc_list; + struct rcu_head gc_rcu; + }; /* * Once inet_peer is queued for deletion (refcnt == -1), following fields * are not available: rid, ip_id_count, tcp_ts, tcp_ts_stamp |