diff options
| author | Jeremy Kerr <jk@codeconstruct.com.au> | 2021-09-29 09:26:08 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-29 12:00:11 +0200 |
| commit | 43f55f23f70881e9c397557f15c8090b368d0af2 (patch) | |
| tree | 8fc42e6056ac109df1e6931763d31891d0f5e016 /include/net/mctpdevice.h | |
| parent | mctp: locking, lifetime and validity changes for sk_keys (diff) | |
| download | linux-43f55f23f70881e9c397557f15c8090b368d0af2.tar.xz linux-43f55f23f70881e9c397557f15c8090b368d0af2.zip | |
mctp: Add refcounts to mctp_dev
Currently, we tie the struct mctp_dev lifetime to the underlying struct
net_device, and hold/put that device as a proxy for a separate mctp_dev
refcount. This works because we're not holding any references to the
mctp_dev that are different from the netdev lifetime.
In a future change we'll break that assumption though, as we'll need to
hold mctp_dev references in a workqueue, which might live past the
netdev unregister notification.
In order to support that, this change introduces a refcount on the
mctp_dev, currently taken by the net_device->mctp_ptr reference, and
released on netdev unregister events. We can then use this for future
references that might outlast the net device.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/mctpdevice.h')
| -rw-r--r-- | include/net/mctpdevice.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/net/mctpdevice.h b/include/net/mctpdevice.h index 71a11012fac7..3a439463f055 100644 --- a/include/net/mctpdevice.h +++ b/include/net/mctpdevice.h @@ -17,6 +17,8 @@ struct mctp_dev { struct net_device *dev; + refcount_t refs; + unsigned int net; /* Only modified under RTNL. Reads have addrs_lock held */ @@ -32,4 +34,7 @@ struct mctp_dev { struct mctp_dev *mctp_dev_get_rtnl(const struct net_device *dev); struct mctp_dev *__mctp_dev_get(const struct net_device *dev); +void mctp_dev_hold(struct mctp_dev *mdev); +void mctp_dev_put(struct mctp_dev *mdev); + #endif /* __NET_MCTPDEVICE_H */ |