diff options
author | Adrian Moreno <amorenoz@redhat.com> | 2024-07-04 10:56:55 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-07-06 02:45:47 +0200 |
commit | 7b1b2b60c63f070e0dfbe072ccaae13168b38d01 (patch) | |
tree | 68420e693c20aacac7c60dd3407418c29126787b /include/net/psample.h | |
parent | net: psample: skip packet copy if no listeners (diff) | |
download | linux-7b1b2b60c63f070e0dfbe072ccaae13168b38d01.tar.xz linux-7b1b2b60c63f070e0dfbe072ccaae13168b38d01.zip |
net: psample: allow using rate as probability
Although not explicitly documented in the psample module itself, the
definition of PSAMPLE_ATTR_SAMPLE_RATE seems inherited from act_sample.
Quoting tc-sample(8):
"RATE of 100 will lead to an average of one sampled packet out of every
100 observed."
With this semantics, the rates that we can express with an unsigned
32-bits number are very unevenly distributed and concentrated towards
"sampling few packets".
For example, we can express a probability of 2.32E-8% but we
cannot express anything between 100% and 50%.
For sampling applications that are capable of sampling a decent
amount of packets, this sampling rate semantics is not very useful.
Add a new flag to the uAPI that indicates that the sampling rate is
expressed in scaled probability, this is:
- 0 is 0% probability, no packets get sampled.
- U32_MAX is 100% probability, all packets get sampled.
Reviewed-by: Aaron Conole <aconole@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Link: https://patch.msgid.link/20240704085710.353845-5-amorenoz@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net/psample.h')
-rw-r--r-- | include/net/psample.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/net/psample.h b/include/net/psample.h index 2ac71260a546..c52e9ebd88dd 100644 --- a/include/net/psample.h +++ b/include/net/psample.h @@ -24,7 +24,8 @@ struct psample_metadata { u8 out_tc_valid:1, out_tc_occ_valid:1, latency_valid:1, - unused:5; + rate_as_probability:1, + unused:4; const u8 *user_cookie; u32 user_cookie_len; }; |