diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-02-15 18:02:12 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-16 12:21:04 +0100 |
| commit | 8d23a54f5beea59b560855fb571e5d73d783e0b4 (patch) | |
| tree | 146a1590d46062778c5dd7d2d4acc78916afd2bb /include/net/switchdev.h | |
| parent | net: bridge: vlan: notify switchdev only when something changed (diff) | |
| download | linux-8d23a54f5beea59b560855fb571e5d73d783e0b4.tar.xz linux-8d23a54f5beea59b560855fb571e5d73d783e0b4.zip | |
net: bridge: switchdev: differentiate new VLANs from changed ones
br_switchdev_port_vlan_add() currently emits a SWITCHDEV_PORT_OBJ_ADD
event with a SWITCHDEV_OBJ_ID_PORT_VLAN for 2 distinct cases:
- a struct net_bridge_vlan got created
- an existing struct net_bridge_vlan was modified
This makes it impossible for switchdev drivers to properly balance
PORT_OBJ_ADD with PORT_OBJ_DEL events, so if we want to allow that to
happen, we must provide a way for drivers to distinguish between a
VLAN with changed flags and a new one.
Annotate struct switchdev_obj_port_vlan with a "bool changed" that
distinguishes the 2 cases above.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/switchdev.h')
| -rw-r--r-- | include/net/switchdev.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/include/net/switchdev.h b/include/net/switchdev.h index d353793dfeb5..92cc763991e9 100644 --- a/include/net/switchdev.h +++ b/include/net/switchdev.h @@ -81,6 +81,13 @@ struct switchdev_obj_port_vlan { struct switchdev_obj obj; u16 flags; u16 vid; + /* If set, the notifier signifies a change of one of the following + * flags for a VLAN that already exists: + * - BRIDGE_VLAN_INFO_PVID + * - BRIDGE_VLAN_INFO_UNTAGGED + * Entries with BRIDGE_VLAN_INFO_BRENTRY unset are not notified at all. + */ + bool changed; }; #define SWITCHDEV_OBJ_PORT_VLAN(OBJ) \ |