diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-07-30 05:15:07 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-08-03 03:35:16 +0200 |
| commit | e4c4e448cf557921ffbbbd6d6ddac81fdceacb4f (patch) | |
| tree | 6813f4b0228e1ec26c26c5c56ef980a2a7c0963c /include/net | |
| parent | IPVS: use pr_err and friends instead of IP_VS_ERR and friends (diff) | |
| download | linux-e4c4e448cf557921ffbbbd6d6ddac81fdceacb4f.tar.xz linux-e4c4e448cf557921ffbbbd6d6ddac81fdceacb4f.zip | |
neigh: Convert garbage collection from softirq to workqueue
Current neigh_periodic_timer() function is fired by timer IRQ, and
scans one hash bucket each round (very litle work in fact)
As we are supposed to scan whole hash table in 15 seconds, this means
neigh_periodic_timer() can be fired very often. (depending on the number
of concurrent hash entries we stored in this table)
Converting this to a workqueue permits scanning whole table, minimizing
icache pollution, and firing this work every 15 seconds, independantly
of hash table size.
This 15 seconds delay is not a hard number, as work is a deferrable one.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/neighbour.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/net/neighbour.h b/include/net/neighbour.h index d8d790e56d3d..18b69b6cecaf 100644 --- a/include/net/neighbour.h +++ b/include/net/neighbour.h @@ -24,6 +24,7 @@ #include <linux/err.h> #include <linux/sysctl.h> +#include <linux/workqueue.h> #include <net/rtnetlink.h> /* @@ -167,7 +168,7 @@ struct neigh_table int gc_thresh2; int gc_thresh3; unsigned long last_flush; - struct timer_list gc_timer; + struct delayed_work gc_work; struct timer_list proxy_timer; struct sk_buff_head proxy_queue; atomic_t entries; @@ -178,7 +179,6 @@ struct neigh_table struct neighbour **hash_buckets; unsigned int hash_mask; __u32 hash_rnd; - unsigned int hash_chain_gc; struct pneigh_entry **phash_buckets; }; |